Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix US locale datetime parsing #2262

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Fix US locale datetime parsing #2262

merged 1 commit into from
Jun 24, 2023

Conversation

adetsi
Copy link
Contributor

@adetsi adetsi commented Jun 20, 2023 •
edited
Loading

Fix for isssue( #1312 ) where US locale string format ("%m/%d/%Y, %I:%M:%S %p") is parsed wrongly by emscripten compiler. eg. "03/15/2020, 11:30:45 AM" is incorrectly parsed as "03/15/2020, 11:30:45 PM"

Before Implementation - Test Fails
after_time_implementation_1

After Implementations - Test Passes
After_time_implementation

@adetsi
Copy link
Contributor Author

adetsi commented Jun 23, 2023 •
edited
Loading

@texodus / @sc1f / @timkpaine could you please review my PR on issue #1312

texodus
texodus approved these changes Jun 24, 2023
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit da265c9 into finos:master Jun 24, 2023
@texodus texodus added the bug Concrete, reproducible bugs label Jun 24, 2023
@texodus texodus changed the title Write custom parser for us locale time string format Fix US locale datetime parsing Jun 24, 2023
@texodus texodus changed the title Fix US locale datetime parsing Fix US locale datetime parsing Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
bug Concrete, reproducible bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adetsi @texodus