Fix workspace save() w/settings
#2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
fix-workspace-save-settings
branch
from
1c82696 to
21c4d2b
Compare
texodus
force-pushed
the
fix-workspace-save-settings
branch
from
21c4d2b to
146bf72
Compare
texodus
force-pushed
the
fix-workspace-save-settings
branch
from
ae866fb to
d639fdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
@finos/perspective-workspace'ssave()method when called with the settings panel open, which previously yielded JSON which does not recreate the GUI when provided torestore().