Validate installed emsdk version #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
reviewed
Jun 13, 2023
There was a problem hiding this comment.
Thanks for the PR! This is a good idea. The CI build failed with a curious error which needs to be fixed first.
Historically, Perspective does not use .sh scripts because we supported building on Windows. We don't currently test this anywhere that requires emsdk, but maybe worth just moving this logic into JavaScript section as it is currently the solo .sh in the repo, since it doesn't work on CI anyway :)
This ensures that the version installed on a developer's clone matches what's in package.json may want to catch the error + add some instructions to fix the problem
The build error you get when emsdk has drifted out of date looks like:
error: error: tool is not installed and therefore cannot be activated: 'releases-adedc0750c4a89b65bee866edab24298cb8d6677-64bit'
Command failed: cd /Users/tom/perspective/perspective/.emsdk && . ./emsdk_env.sh >/dev/null 2>&1 && emsdk activate 3.1.36 >/dev/null && cd /Users/tom/perspective/perspective/cpp/perspective && node ./build.js
The resolution to this now is to run `node scripts/install_emsdk.js`.
Previously it wouldn't install the current emsdk version unless the
developer first rm-rfed .emsdk
It's also still cheap to run the script when the current version is
already installed.
texodus
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Thanks for the PR! Looks good!
One potential issue I have not tested:
- User has old emsdk installed.
- Upgrades Perspective repo to a version that needs a newer emsdk.
activatedoesn't work because upgraded version is not installed yet.
... though the emsdk error on trying to activate this version should be descriptive enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
It's easy to forget to upgrade Emscripten when perspective updates, and your penalty if you forget is you might see weird build errors. Update run_emsdk.js to additionally check the version with
emsdk activateChangelog
Testing
emscriptenversion in package.json, then run:scripts/run_emsdk.js echo hello world