Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sum aggregate for integer type expression columns #2216

Merged
merged 1 commit into from
May 7, 2023
Merged

Fix sum aggregate for integer type expression columns #2216

merged 1 commit into from
May 7, 2023
+89 −22

Conversation

zxy994
Copy link
Contributor

@zxy994 zxy994 commented May 6, 2023

#2036 Column expr of integer column sum renders all rows as 0

BEFORE:
image

AFTER:
image

@zxy994 zxy994 force-pushed the finos/fix-2036 branch 2 times, most recently from 0e47b8d to 497da69 Compare May 7, 2023 07:14
@zxy994 zxy994 force-pushed the finos/fix-2036 branch 3 times, most recently from 497da69 to 29ee00a Compare May 7, 2023 10:48
@zxy994 zxy994 marked this pull request as ready for review May 7, 2023 10:52
texodus
texodus approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@texodus texodus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

I had some comments for the draft version of this PR but you've addressed them and added some additional tests :)

Fixes #2036

@texodus texodus linked an issue May 7, 2023 that may be closed by this pull request
Column expr of integer column sum renders all rows as 0. #2036
Closed
@texodus texodus changed the title fix "Col expr of int cols sum render rows 0 -2036" Fix sum aggregate for integer type expression columns May 7, 2023
@texodus texodus merged commit 46e97ec into finos:master May 7, 2023
@zxy994
Copy link
Contributor Author

zxy994 commented May 7, 2023

@texodus Thanks for the review!

@texodus texodus added the bug Concrete, reproducible bugs label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
bug Concrete, reproducible bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Column expr of integer column sum renders all rows as 0.
2 participants
@zxy994 @texodus