Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename context menu names for perspective renderers in jupyterlab #2209

Merged
merged 1 commit into from
Apr 29, 2023
Merged

rename context menu names for perspective renderers in jupyterlab #2209

merged 1 commit into from
Apr 29, 2023

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Apr 28, 2023 •
edited
Loading

I think these names look a bit cleaner than the original ones.

@timkpaine timkpaine added internal Internal refactoring and code quality improvement JS Jupyter labels Apr 28, 2023
@timkpaine timkpaine marked this pull request as ready for review April 28, 2023 18:39
texodus
texodus approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit 2f80578 into master Apr 29, 2023
@texodus texodus deleted the tkp/renamerightclick branch April 29, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement JS Jupyter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @texodus