Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass through WebSocket connection arguments in Python WebSocket clients, normalize max message size and ensure set for aiohttp #2187

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Pass through WebSocket connection arguments in Python WebSocket clients, normalize max message size and ensure set for aiohttp #2187

merged 1 commit into from
Apr 13, 2023

Conversation

timkpaine
Copy link
Member

fixes #2185

@timkpaine
pass through websocket connection arguments in python websocket clien…
a4e2705 
…ts, normalize max message size and ensure set for aiohttp, fixes #2185
@texodus texodus added the bug Concrete, reproducible bugs label Apr 13, 2023
texodus
texodus approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit 1adc989 into master Apr 13, 2023
@texodus texodus deleted the tkp/wsclient branch April 13, 2023 21:00
@texodus texodus changed the title pass through websocket connection arguments in python websocket clients, normalize max message size and ensure set for aiohttp Pass through WebSocket connection arguments in Python WebSocket clients, normalize max message size and ensure set for aiohttp Apr 13, 2023
@uglybug uglybug mentioned this pull request Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
bug Concrete, reproducible bugs Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PerspectiveAIOHTTPWebsocketConnection does not set max_msg_size
2 participants
@timkpaine @texodus