Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that Yarn v1 must be used in development docs. #2143

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

brochington
Copy link
Contributor

This PR adds a small line to the development docs specifying that Yarn v1 must be used to build the Perspective project.

@finos-cla-bot
Copy link

finos-cla-bot bot commented Mar 20, 2023

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Broch Stilley

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

@timkpaine
Copy link
Member

@brochington check your gitconfig, this commit is not attributed to you so the bot is actually correct here 😭

@brochington brochington force-pushed the feature/yarn-v1-in-docs branch from c722226 to c33b1f4 Compare March 20, 2023 22:48
@finos-cla-bot
Copy link

finos-cla-bot bot commented Mar 20, 2023

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Broch Stilley

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

@timkpaine
Copy link
Member

ok now the bot is wrong 😆

@timkpaine timkpaine added the documentation Improvements/bugs/changes to documentation label Mar 23, 2023
@texodus
Copy link
Member

texodus commented Mar 24, 2023

Thanks for the PR! Looks good!

@texodus texodus merged commit 32c39e3 into finos:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements/bugs/changes to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants