Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecated features in GitHub actions #2141

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Conversation

pvpswaghd
Copy link
Contributor

Followed by Issue #2140 , I have modified the deprecated set-output commands into the new GITHUB_OUTPUT environment.

@finos-cla-bot
Copy link

finos-cla-bot bot commented Mar 19, 2023

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@pvpswaghd).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

cc @TheJuanAndOnly99 @mcleo-d

@finos finos deleted a comment from finos-cla-bot bot Mar 19, 2023
@pvpswaghd
Copy link
Contributor Author

Not sure why CLA is not verified, but I did follow the steps and authroized for my first commit.

@texodus
Copy link
Member

texodus commented Mar 20, 2023

@pvpswaghd Apologies about the CLA bot - it has been broken for years (does not update on submission) and @maoo @TheJuanAndOnly99 do not follow up on administering the CLA process, hence we tend to just ignore it.

Thanks for the PR! I need to review the GitHub Actions docs to determine whether this is the refactor we want - I suspect we actually want to use the build-in env support for workflows rather than using bash for these.

Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Fixes #2140

@texodus texodus merged commit 83f2919 into finos:master Mar 24, 2023
@texodus texodus added the internal Internal refactoring and code quality improvement label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants