Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guidelines #2077

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Update contributing guidelines #2077

merged 1 commit into from
Feb 22, 2023

Conversation

texodus
Copy link
Member

@texodus texodus commented Jan 1, 2023

No description provided.

@texodus texodus added the documentation Improvements/bugs/changes to documentation label Jan 1, 2023
Copy link
Contributor

@sinistersnare sinistersnare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +33 to +35
- Complete your
[FINOS CLA](https://finosfoundation.atlassian.net/wiki/spaces/FINOS/pages/75530375/Contribution+Compliance+Requirements#ContributionComplianceRequirements-ContributorLicenseAgreement)
_before_ opening a PR.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this PR should include a PR template that asks a user to assert that they signed the CLA before submitting.

@texodus texodus merged commit 2f0a3a0 into master Feb 22, 2023
@texodus texodus deleted the update-contirbuting branch February 22, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements/bugs/changes to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants