Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 support, deprecate 3.7 #2065

Merged
merged 7 commits into from
Dec 28, 2022
Merged

Add Python 3.10 support, deprecate 3.7 #2065

merged 7 commits into from
Dec 28, 2022

Conversation

texodus
Copy link
Member

@texodus texodus commented Dec 28, 2022

Fixes perspective-python, deprecates support for Python 3.7 and adds 3.10.

  • Fixes symbol visibility to prevent libarrow from other python libraries (e.g. pyarrow) from binding to Perspective, causing various obscure segfaults.
  • Remove support for DTYPE_OBJECT, which was incomplete anyway. This type is still needed for e.g. marshalling pandas object columns, but error if (somehow?) forced into the schema of a Table.
  • Remove 3.7, add 3.10 to CI.
  • Fix the clean development task which had regressed due to changed behavior of node/rimraf.
  • Fix compatibility with numpy 1.24.0 (which itself deprecates Python 3.7).
  • Adds a cmake warning for python sdist installs (fixes Python sdist install error messages are _terrible_ #2063).

full build

@texodus texodus force-pushed the dtype_object branch 3 times, most recently from 59bb066 to 5d99838 Compare December 28, 2022 04:13
@texodus texodus added bug Concrete, reproducible bugs breaking labels Dec 28, 2022
@texodus texodus marked this pull request as ready for review December 28, 2022 06:42
@texodus texodus changed the title WIP Add Python 3.10 support, deprecate 3.7 Dec 28, 2022
@texodus texodus merged commit dbb4293 into master Dec 28, 2022
@texodus texodus deleted the dtype_object branch December 28, 2022 12:44
@timkpaine timkpaine mentioned this pull request Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python sdist install error messages are _terrible_
2 participants