Fix parsing of bug related to d3fc splitting selection data (redux of #2039) #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
approved these changes
Dec 10, 2022
| @@ -32,7 +32,7 @@ function addDataValues(tooltipDiv, values) { | |||
| } | |||
|
|
|||
| const formatNumber = (value) => | |||
| value === null | |||
| value === null || value === undefined | |||
There was a problem hiding this comment.
This is fine but just out of curiosity does this actually do anything? Perspective's APIs should not return undefined, only null for missing cells (in theory).
There was a problem hiding this comment.
I totally agree. I'm not a fan of undefined either, and this was a "defensive" change. Currently there is somehow a case where type can be undefined, but should maybe be an enum variant, or optional string.
|
|
||
| if (data.key) { | ||
| splitValues = data.key.split("|"); | ||
| } else if (data.mainValue?.split) { |
There was a problem hiding this comment.
I presume this ? is the failing logic :)
There was a problem hiding this comment.
Yup, pretty much. The default case of [data.mainValue] was never being reached.
| @@ -143,4 +143,24 @@ describe("tooltip generateHTML should", () => { | |||
| "main-1: 101", | |||
| ]); | |||
| }); | |||
|
|
|||
| test("Provide default number formatting for null and undefined types", () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a bug where selection data text splitting logic will throw an error if certain values of the data (key and mainValue properties) are not "splittable". This PR aims to correct the logic surrounding this splitting of values.
redo of a previous PR