Fix Sunburst chart infinite loop bug #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within sunburst charts, labels must be calculated (or not) depending on whether they will physically fit in their respective slices, and this can only practically be done by measuring the text after its been rendered. When a sunburst chart is drawn but not visible, e.g. in the case of a
<perspective-workspace>panel that is "unselected" but still _connected" from the perspective of the Shadow DOM, this can result in an infinite loop, as most geometry calculations e.g.getBoundingClientRect()will not return the correct values when they're not "visible". This PR changes the initialization logic for charts, only rendering them fully when theiroffsetParentis non-null.Fixes #1938 and adds a test case derived from the repro in this issue.