Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python sdist CI build #1907

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Fix Python sdist CI build #1907

merged 1 commit into from
Jul 11, 2022

Conversation

texodus
Copy link
Member

@texodus texodus commented Jul 11, 2022 •
edited
Loading

@texodus texodus requested a review from timkpaine as a code owner July 11, 2022 14:52
@texodus texodus added internal Internal refactoring and code quality improvement and removed cla-present labels Jul 11, 2022
@texodus
Copy link
Member Author

texodus commented Jul 11, 2022

still fail

@texodus texodus marked this pull request as draft July 11, 2022 18:45
@timkpaine
Copy link
Member

perspective/python/perspective/setup.cfg

Line 20 in 0e3e3d6

asyncio_mode=strict
Try adding the pytest command line arg for this

timkpaine
timkpaine approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@timkpaine timkpaine left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously we want to get away from enumerating deps in multiple places (which I think we can do by installing *.whl[develop]) but good for now

@texodus texodus marked this pull request as ready for review July 11, 2022 22:55
@texodus texodus merged commit f2aa989 into master Jul 11, 2022
@texodus texodus deleted the fix-sdist branch July 11, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timkpaine timkpaine timkpaine approved these changes

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texodus @timkpaine