Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin tornado to 6.1 in CI #1886

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Pin tornado to 6.1 in CI #1886

merged 1 commit into from
Jul 4, 2022

Conversation

texodus
Copy link
Member

@texodus texodus commented Jul 4, 2022

Perspective/Jupyterlab tests dump random errors coincident with the release of Tornado 6.2 today. I don't yet know if this is an existing bug in Perspective that has been exposed, or in JupyterLab or Tornado, so I have not modified the setup.py bounds.

I'll be looking into removing the manual dependency installation from azure as well, as IMO it is unacceptable to have CI break when dependencies change.

Exception in callback <TaskWakeupMethWrapper object at 0x10dd9f1c0>(<Future finis... GMT\r\n\r\n'>)
handle: <Handle <TaskWakeupMethWrapper object at 0x10dd9f1c0>(<Future finis... GMT\r\n\r\n'>)>
Traceback (most recent call last):
  File "/usr/local/Cellar/python@3.9/3.9.10/Frameworks/Python.framework/Versions/3.9/lib/python3.9/asyncio/events.py", line 80, in _run
    self._context.run(self._callback, *self._args)
RuntimeError: Cannot enter into task <Task pending name='Task-13' coro=<HTTP1ServerConnection._server_request_loop() running at /usr/local/lib/python3.9/site-packages/tornado/http1connection.py:825> wait_for=<Future finished result=b'GET /static...7 GMT\r\n\r\n'> cb=[IOLoop.add_future.<locals>.<lambda>() at /usr/local/lib/python3.9/site-packages/tornado/ioloop.py:687]> while another task <Task pending name='Task-224' coro=<PeriodicCallback._run() running at /usr/local/lib/python3.9/site-packages/tornado/ioloop.py:921> cb=[IOLoop.add_future.<lo

@texodus texodus added the internal Internal refactoring and code quality improvement label Jul 4, 2022
@texodus texodus requested a review from timkpaine as a code owner July 4, 2022 03:42
@texodus texodus merged commit a85d6e4 into master Jul 4, 2022
@texodus texodus deleted the fix-tornado-regression-ic branch July 4, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timkpaine timkpaine Awaiting requested review from timkpaine

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@texodus