Fix jupyterlab test timeouts #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
added
internal
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes the persistent Jupyter test failures which have plagued our CI recently, though the nature of intermittent test failures on CI means I cannot be certain.
Replaces an arbitrary timeout with a
waitForSelector()that tests for the presence of an"idle"kernel before executing a keyboard command to run Jupyter cells. Though I am not sure this was the source of the timeout on CI, removing this 1000ms timeout consistently failed these tests, and in non-headless mode I observed instances of the keyboard commands firing before the kernel reported"idle".