Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support autocomplete for IN filter type #1798

Merged
merged 1 commit into from
May 10, 2022
Merged

Support autocomplete for IN filter type #1798

merged 1 commit into from
May 10, 2022

Conversation

spff
Copy link
Contributor

@spff spff commented May 5, 2022

No description provided.

@finos-cla-bot
Copy link

finos-cla-bot bot commented May 5, 2022

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Jim Chang

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

@texodus texodus added the enhancement Feature requests or improvements label May 5, 2022
@finos-cla-bot
Copy link

finos-cla-bot bot commented May 9, 2022

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@spff).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

cc @maoo @TheJuanAndOnly99 @mcleo-d

Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

I may play around a bit with the UX in the future (would like to get a pillbox UX), but this is already a vast improvement over the current version.

@texodus texodus merged commit e2005e4 into finos:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants