Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toolbar icons configurable #1767

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

kevinhinterlong
Copy link
Contributor

Fixes alignment of theme dropdown and scroll lock/edit label

image
image

@finos-cla-bot
Copy link

finos-cla-bot bot commented Mar 14, 2022

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@kevinhinterlong).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

cc @maoo @TheJuanAndOnly99 @mcleo-d

Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Can you please share some details on the intent behind the flex changes? These are inert in the current DOM structure, and I don't see any difference in your screenshots or my testing to 1.3.5, so I expect that you're doing something unexpected (or unintended) with your custom styling.

@texodus
Copy link
Member

texodus commented Mar 19, 2022

Thanks for the PR! Looks good!

@texodus texodus merged commit 91ade3c into finos:master Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants