Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust lint+nightly #1760

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Rust lint+nightly #1760

merged 2 commits into from
Mar 14, 2022

Conversation

texodus
Copy link
Member

@texodus texodus commented Mar 13, 2022 •
edited
Loading

The net effect of these changes is a ~12% code size reduction for perspective-viewer.

  • Use nightly rust toolchain (but still rust stable language subset).
  • Use updated rustfmt and clippy settings from nightly.
  • Remove wasm-pack for build (still needed for tests for now due to chromedriver resolution ...)
  • Refactor rust to correct new warnings/lint + cleanup.

@texodus texodus force-pushed the rust-clippy branch 5 times, most recently from 4f584b7 to e0826aa Compare March 14, 2022 03:32
@texodus texodus marked this pull request as ready for review March 14, 2022 05:29
@texodus texodus added the internal Internal refactoring and code quality improvement label Mar 14, 2022
@texodus texodus merged commit 4c8a0dd into master Mar 14, 2022
@texodus texodus deleted the rust-clippy branch March 14, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@texodus