Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual column selector #1722

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Virtual column selector #1722

merged 1 commit into from
Feb 23, 2022

Conversation

texodus
Copy link
Member

@texodus texodus commented Feb 21, 2022

This PR improves render performance of the <perspective-viewer> column selector control, specifically in the presence of a large number of columns, by:

  • Optimizing the column selector iteration code to remove unnecessary copies.
  • Making active columns virtualized by viewport.

@texodus texodus linked an issue Feb 21, 2022 that may be closed by this pull request
@texodus texodus force-pushed the virtual-column-selector branch 4 times, most recently from 0811e33 to e5cc80e Compare February 22, 2022 10:34
@texodus texodus marked this pull request as ready for review February 22, 2022 10:52
@texodus texodus force-pushed the virtual-column-selector branch from e5cc80e to 18dfa86 Compare February 22, 2022 20:15
@texodus texodus added the bug Concrete, reproducible bugs label Feb 22, 2022
@texodus texodus merged commit df79093 into master Feb 23, 2022
@texodus texodus deleted the virtual-column-selector branch February 23, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General performance question for wide datasets (400+ columns)
1 participant