CSV output rewrite (Arrow/C++) #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
arrow-csv
branch
2 times, most recently
from
2fc6091 to
0209d34
Compare
texodus
force-pushed
the
arrow-csv
branch
2 times, most recently
from
e66d6cc to
4d7d0e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1666, fixes #1690
View.to_csv()in C++ using Arrow's CSV support, making CSV writing consistent across Python and JavaScript.View.to_arrow()(and by extension.to_csv()), to include individual row pivot columns (namedColumn Name (Group by #)). This was previously unimplemented for.to_arrow(), and rendered as a single,separated link from.to_csv()(which is conflated with the CSV's own,causing CSV output withrow_pivots> 1 don't render correctly #1666).As a side effect, the performance of
.to_csv()methods has been increased ~4x for both Python and JavaScript.