-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build windows wheel every time so its tested #1672
Conversation
6bb6613
to
7c4e249
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks good!
I've squashed these commits so the git history will be legible.
What's the reasoning behind a Windows build and a Windows wheel build? I would like to limit the python builds per commit to 1 per OS if possible, these builds back up when many commits are raised in a short period and lead to multiple-hour delays due to lack of Azure slots. I can change the publish script to require a passing full-build CI to prevent regressions being published, if thats the intent of testing both of these. |
Windows build followed by windows wheel takes > 60 minutes. We should check windows wheel on every commit, and during release we should run all the windows source builds and windows wheel builds (but can't be in same step cause it will time out). I think windows builds are actually more available than Mac builds, so the two Mac builds per PR are a bigger issue |
Seems like the only changes which risk breaking Windows wheel build are C++ dependency changes, changes to the Python build process, and the occasional Azure or conda environment change; all of which are relatively infrequent and are still verified by running a full build. Granted, I've done a bad job of remembering to check a full build when approving PRs in these areas. I'd like to explore ways to make these exceptional checks befitting their rarity - if we cut 1 Windows build and 1 OSX build, we'll go from 6->4 jobs per PR and 2->3 average concurrent builds capacity. |
I've dropped to:
|
Glorious |
#1668 against master