-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to esbuild
#1611
Merged
Port to esbuild
#1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome dependency versions
timkpaine
reviewed
Nov 16, 2021
@@ -5,7 +5,7 @@ | |||
"description": "An example app built using `@finos/perspective-workspace`.", | |||
"scripts": { | |||
"start": "webpack serve --open", | |||
"webpack": "webpack --colour" | |||
"webpack": "webpack --color" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇺🇸
timkpaine
reviewed
Nov 16, 2021
timkpaine
reviewed
Nov 16, 2021
timkpaine
reviewed
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
webpack
androllup
composite build withesbuild
, substantially improving the developer experience, as all JavaScript/TypeScript/CSS assets can be built in under 10 seconds, as opposed to 2-3 minutes on webpack.@finos/perspective-webpack-plugin
still works and can build these assets via webpack, so this change should really only affect how perspective is built for packaging.The main potentially-breaking change is that NPM packages have moved from
"main"
/"module"
/"browser"
/etc key menagerie to"externals"
, which is only supported bywebpack
^5
and node12.7.1
. Forwebpack
, while support for version^4
was already deprecated in@finos/perspective-webpack-plugin
, perspective could still be built without the plugin using the package's UMD module output (the default); this is no longer the case, though older webpack versions should still be able to link directly to the UMD filepath within the module, e.g.@finos/perspective/dist/umd/perspective.js
. Note also thatexternals
, unlike the previous package descriptors, makes other files private by default, so there is some risk of unexpected file resolution issues if a package imports something we did not expect.