Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated webpack-specific tilde prefix convention #1582

Merged
merged 2 commits into from
Oct 16, 2021

Conversation

timkpaine
Copy link
Member

With the existing webpack-specific tilde convention, other bundlers have difficulty managing perspective's .less files so they need to be vendored separately (e.g. with esbuild iam-medvedev/esbuild-plugin-less#15 (comment) and i have had some trouble with rollup as well).

According to this less-loader doc, the tilde is deprecated as the resolution will fail over to node_modules anyway.

@timkpaine timkpaine added internal Internal refactoring and code quality improvement JS labels Oct 14, 2021
@texodus
Copy link
Member

texodus commented Oct 16, 2021

Looks good! Thanks for the PR!

@texodus texodus merged commit ea2bd63 into finos:master Oct 16, 2021
@timkpaine timkpaine deleted the webpacktilde branch December 11, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants