Lint upgrade and remove TypeScript for @finos/perspective-jupyterlab
#1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
texodus
force-pushed
the
eslint-update
branch
from
790a775 to
22d6b98
Compare
texodus
force-pushed
the
eslint-update
branch
from
22d6b98 to
f3d53c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
eslint,prettierand associated extensions to their latest versions, such that linting will work consistently and correctly acrossgitclients, IDEs, CI environments and such.While perspective has had comprehensive enforced lint for a while, it had bit-rotted due to various accumulated incompatibilities and developer grievances. Some paths were excluded, and some
errorshad becomewarningsor disabled entirely. In this PR,lintis restored to a CI requirement, PRs will fail if they do not pass clean lint. Alllintautofix rules have been applied for ~15k lines updated (as user "no author").As a consequence of these new development restrictions, the technical debt associated with
@finos/perspective-jupyterlabhas come to a head, and so this PR also ports this package from TypeScript to JavaScript. The type topography of this package was ill-conceived and required multiple hacks that now fail lint, and I'm not interested in fixing them (IMO we should re-write this package completely with a goal of simplicity, 1:1 correspondance with the perspective API, and a bespoke data transport to overcome the performance issues associated with traits). Supercedes #1344