Refactor to_arrow
, fix row deltas for pivoted views
#1519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes refactors to
to_arrow
so that it better matches the behavior ofto_format
by skipping hidden sorts, fixing bugs that occurred when emitting deltas for 1 and 2-sided contexts, which in many situations were completely incorrect. Additionally, theunique
aggregate now emitsnull
for non-unique string values instead of the string"-"
, which is not semantically correct. A large number of tests have also been added to ensure correctness.