Add to_csv to view object #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segarman
commented
Jul 9, 2018
| @@ -541,12 +518,6 @@ view.prototype.to_json = async function(options) { | |||
|
|
|||
| let data; | |||
|
|
|||
| if (options.format && options.format === "table") { | |||
There was a problem hiding this comment.
removed this since it will break anyways, prev line 558 was always calling data.push which will fail if data was an object
Merged
|
I've rebased and merged these in #150 - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, will write tests once I can get a local build of perspective