Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required dependencies for webpack plugin #1480

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Add required dependencies for webpack plugin #1480

merged 1 commit into from
Jul 16, 2021

Conversation

LukeSheard
Copy link
Contributor

  • Resolve loaders relative to the current package location to ensure that the perspective version of loaders is picked up.
  • Add required dependencies for webpack plugin, currently when installing into a repository without string-replace-loader builds will start failing due to the missing dependency.

texodus
texodus approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@texodus texodus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the PR!

@texodus texodus merged commit fd29999 into finos:master Jul 16, 2021
@texodus texodus added the bug Concrete, reproducible bugs label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
bug Concrete, reproducible bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukeSheard @texodus