Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Boost from JFrog, fix outdated docs from #1409 #1410

Merged
merged 2 commits into from
May 3, 2021
Merged

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented May 3, 2021

As of May 1, Bintray has been sunset which causes our install_tools.js to fail when trying to install Boost.

This PR removes all Bintray links and replaces them with a link to the Boost artefact in JFrog, from the link provided on the Boost website. Dockerfiles have also been updated to use the JFrog link to prevent any build issues.

Additionally, it fixes the outdated docs mentioned in #1409 by removing Unpkg alias links and replacing them with direct links to the /dist/umd folder.

Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit 2322c90 into master May 3, 2021
@texodus texodus deleted the bintray branch May 3, 2021 08:36
@texodus texodus added internal Internal refactoring and code quality improvement documentation Improvements/bugs/changes to documentation labels May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements/bugs/changes to documentation internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants