Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
puppeteer
, which uncovered a slew of timing errors in Perspective's visual-regression test suite. To help rectify this:perspective-viewer
flush()
and internal_update()
methods now use a async-aware debounce method borrowed fromregular-table
, modified to allow settings the"updating"
flag only when this debounced method is idle.perspective-workspace
now callsMessageLoop.flush()
in a number of places where perspective would expect side effects to either live in a Promise or happen synchronously.azure-pipelines.yml
to publish screenshots when JavaScript tests fail. This is only partially useful since there are no reference screenshots to diff on CI, but it is better than nothing.