Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade puppeteer to 9.0.0 #1408

Merged
merged 1 commit into from
May 1, 2021
Merged

Upgrade puppeteer to 9.0.0 #1408

merged 1 commit into from
May 1, 2021

Conversation

texodus
Copy link
Member

@texodus texodus commented May 1, 2021

Upgrades puppeteer, which uncovered a slew of timing errors in Perspective's visual-regression test suite. To help rectify this:

  • perspective-viewer flush() and internal _update() methods now use a async-aware debounce method borrowed from regular-table, modified to allow settings the "updating" flag only when this debounced method is idle.
  • perspective-workspace now calls MessageLoop.flush() in a number of places where perspective would expect side effects to either live in a Promise or happen synchronously.
  • Several tests have their conditions streamlined.
  • Modified azure-pipelines.yml to publish screenshots when JavaScript tests fail. This is only partially useful since there are no reference screenshots to diff on CI, but it is better than nothing.

@texodus texodus added the internal Internal refactoring and code quality improvement label May 1, 2021
@texodus texodus added this to the 0.8.1 milestone May 1, 2021
@texodus texodus merged commit 10fb6f6 into master May 1, 2021
@texodus texodus deleted the upgrade-puppeteer-2 branch May 1, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant