Add call_loop and get_table_names
#1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two methods to the
PerspectiveManagerAPI:call_loop(fn, *args, **kwargs): callsfnon theloop_callbackof the manager, or raises aPerspectiveErrorif the loop callback is not set.This allows users to make calls on the Perspective thread without having to deal with the
_loop_callbackproperty of the manager, which is ostensibly private but (until now) lacked a public API.get_table_names(): Returns a list of the tables hosted on the manager by name.A common use case is to query the managers' private
_tablesand_viewsdictionaries for users to find out which Tables/Views are hosted on a server, which is especially useful in a server-client context where the consumers of the Perspective server may be different than the author of the server.get_table_names()offers a public API that can be called without having to query private properties ofPerspectiveManager.