Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix binder #1341

Merged
merged 2 commits into from
Mar 4, 2021
Merged

fix binder #1341

merged 2 commits into from
Mar 4, 2021

Conversation

timkpaine
Copy link
Member

No description provided.

@timkpaine timkpaine requested a review from sc1f March 3, 2021 22:59
sc1f
sc1f approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@sc1f sc1f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - @timkpaine does binder pull from master, or from the latest disted build?

@timkpaine
Copy link
Member Author

http://beta.mybinder.org/v2/gh/finos/perspective/master?urlpath=lab/tree/examples/jupyter-notebooks

to test off this branch: http://beta.mybinder.org/v2/gh/finos/perspective/binder?urlpath=lab/tree/examples/jupyter-notebooks

@texodus texodus added the internal Internal refactoring and code quality improvement label Mar 4, 2021
@texodus
Copy link
Member

texodus commented Mar 4, 2021

Thanks for the PR! Looks good!

@texodus texodus merged commit 5574821 into master Mar 4, 2021
@texodus texodus deleted the binder branch March 4, 2021 17:17
@timkpaine timkpaine mentioned this pull request Mar 4, 2021
Closed
@texodus texodus linked an issue Mar 4, 2021 that may be closed by this pull request
Binder link in README is broken #1339
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc1f sc1f sc1f approved these changes

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binder link in README is broken
3 participants
@timkpaine @texodus @sc1f