Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nightly complete builds #1338

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Add nightly complete builds #1338

merged 2 commits into from
Mar 4, 2021

Conversation

timkpaine
Copy link
Member

resolve issues raised in #1337

@texodus texodus force-pushed the nightlies branch 2 times, most recently from cb99843 to dd6ec0b Compare March 4, 2021 09:38
texodus
texodus approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

I've rebased (to resolve the emsdk regression), and also made these into "weeklies" rather than "nightlies" (just temporarily as I validate how this CI load impacts our dev process).

@texodus texodus merged commit 0cde0fc into master Mar 4, 2021
@texodus texodus deleted the nightlies branch March 4, 2021 17:45
@timkpaine timkpaine mentioned this pull request Mar 4, 2021
Closed
@texodus texodus linked an issue Mar 4, 2021 that may be closed by this pull request
Add periodic testing to CI #1267
Closed
@texodus texodus added the internal Internal refactoring and code quality improvement label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add periodic testing to CI
2 participants
@timkpaine @texodus