Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1324: use ~major.minor.patch in PerspectiveWidget versioning #1331

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Feb 19, 2021

This PR fixes #1324 by using the full version in _model_module_version and _view_module_version, which should fix the scenario described in the issue.

Before, the version strings were ~{MAJOR}.{MINOR}, so ~0.5, ~0.6 etc. Now, the version strings are ~{MAJOR}.{MINOR}.{PATCH}, so the exact version of Perspective as specified in the root package.json: ~0.6.2, etc. With the tilde this should resolve to 0.6.2 < 0.7.0.

@sc1f sc1f requested a review from timkpaine February 19, 2021 20:35
@sc1f sc1f added internal Internal refactoring and code quality improvement Python labels Feb 19, 2021
@timkpaine
Copy link
Member

this introduces a flavor of the same problem, which is that it makes it impossible to upgrade one side without upgrading the other side due to strict semver checking.

e.g. if you want to fix a bug on the python side, you will also have to rebuild and redeploy javascript, even if its not otherwise modified.

@sc1f
Copy link
Contributor Author

sc1f commented Feb 19, 2021

We already do this though - there is no situation in which the version of perspective-python would != the version of the Javascript packages, since the entire versioning scheme is hooked up to lerna dist which updates all lerna-ized packages at The only part that isn't hooked up to lerna dist is disting new versions to pypi, which we are admittedly behind on right now.

@timkpaine
Copy link
Member

timkpaine commented Feb 19, 2021

I have firsthand experience with a framework in which you could control backend updates, but not frontend updates. The reason we switched to this versioning scheme in the first place was to make it easier for your team to get changes out on the backend without worrying about my team getting the JupyterLab extension updated

@texodus
Copy link
Member

texodus commented Feb 20, 2021

@timkpaine I appreciate the insight and acknowledge that this change will make it more difficult for version-restricted/role-partitioned environments to upgrade ... c'est la vie.

@texodus texodus merged commit 283fd5c into master Feb 21, 2021
@texodus texodus deleted the fix-jlab-ver branch February 21, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perspective-python should not use tilde (~) in client version resolution
3 participants