Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Date/Time formatting in perspective-viewer CSV output #1281

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

texodus
Copy link
Member

@texodus texodus commented Jan 7, 2021

Fixes #1265

@sc1f
Copy link
Contributor

sc1f commented Jan 7, 2021

I added a fix - previously, to_csv would only display the date because the Intl.DateTimeFormatter was not configured properly. Now, it will display the date and time for datetime columns, and display the date for date columns.

Additionally, I also fixed CSV export from the viewer on a Python server; because the date_format API is a little different for Python (takes a fmtstring, and not a locale), I defaulted it to the standard "YYYY-MM-DD HH:MM:SS" format.

@texodus texodus force-pushed the csv-datetime-format branch from 6c24194 to 96a2347 Compare January 8, 2021 06:04
@texodus texodus added bug Concrete, reproducible bugs JS Python labels Jan 8, 2021
@texodus texodus merged commit 16511f2 into master Jan 8, 2021
@texodus texodus deleted the csv-datetime-format branch January 8, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs JS Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataframe copy / dump to csv from perspective datetime formatting
2 participants