Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Point to current jupyter examples, and remove out-of-date/broken example #1257

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

ceball
Copy link
Contributor

@ceball ceball commented Dec 4, 2020

I opted for deletion of example.ipynb as (a) there's now a directory of jupyter examples, and (b) example.ipynb is not included in the package. I'd be happy to update example.ipynb instead if that's preferable.

@finos-cla-bot
Copy link

finos-cla-bot bot commented Dec 4, 2020

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement.

Having reviewed our contributor list, we require a CLA for the following people : (@ceball).

If you need help obtaining a CLA, please read the Requirements for Contributions section of our CLA wiki or email help@finos.org with your questions.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request.

cc @finos-admin

@ceball
Copy link
Contributor Author

ceball commented Dec 4, 2020

@finos-admin please update that @ceball is from JPMC

(just copying what I did last time, e.g. #987 (comment))

@ceball
Copy link
Contributor Author

ceball commented Dec 14, 2020

@finos-admin My contributions here should be covered by JPM's CCLA. I'd like to verify that before I embark on any non-trivial contributions. Thanks!

@texodus
Copy link
Member

texodus commented Dec 21, 2020

Thanks for the PR! Appreciate the fix, sorry for the delay.

Apologies about the @finos-cla-bot, I will get this fixed as well.

@texodus texodus merged commit 074a3a3 into finos:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants