Reimplement pandas deconstruction #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkpaine
added
bug
Merged
timkpaine
requested review from
sc1f and
texodus
and removed request for
sc1f
sc1f
suggested changes
Oct 29, 2020
timkpaine
commented
Oct 29, 2020
sc1f
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
Checked out locally - changes, examples and reformatting look good. @texodus we should probably merge this first and rebase, or manually split it into two PRs just so that other PRs aren't mired in merge issues.
Thanks for fixing the datetime issue! It is only a fix for the Python widget side - for a more comprehensive fix we need to target the date parser in JS/C++ and make it more user-friendly.
This was referenced Oct 30, 2020
texodus
force-pushed
the
pandas_repivot
branch
from
14f4ddc to
72721b5
Compare
texodus
force-pushed
the
pandas_repivot
branch
from
aefe6ba to
b3b15c2
Compare
|
Looks good! Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivoted Pandas dataframe deconstruction is fundamentally broken in our current state, as exhibited by a few issues (#1122, #1123, etc). This PR rectifies that problem by better deconstructing pivoted data frames.
Also changed:
Notebooks and test cases for new pandas behavior updated/added.