C++ Datetime Parsing #1220
Merged
C++ Datetime Parsing #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
cpp-date-parser
branch
from
3458b83 to
2c9ede9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implement string parsing for
datetimeanddateperspective types in C++ via thedate.hand Apache Arrow libraries. With this change, moment.js is no longer a requirement of@finos/perspective, shaving ~80kb from the built asset; however, this feature currently is only compatible with Arrow 1.0.1, which means Python cannot use it yet. In the interim, functions such asmake_view()still take adate_parserargument to maintain C++ API compatibility, but this argument will be ignored in the WebAssembly compiled engine.hh:mm:ss.SSSformat removed. This is relatively simple to add back, but it would be nice to settle on the semantics of date-relative formats like this, first.Also addresses two unrelated bugs in the new Arrow-based CSV parser, encountered during testing:
UnixTimestamptParser, as perspective'sto_csv()outputs datetimes in this format (though we should likely remedy this ..). This parser is not used for inference, so a column must be already typed"date"or"datetime"; otherwise a column of timestamps will be inferred as type"integer".to_csv()to escape strings with"characters.