Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit tornado write_message to IOLoop, add websocket tests in Python #1156

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Submit tornado write_message to IOLoop, add websocket tests in Python #1156

merged 2 commits into from
Aug 26, 2020

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Aug 18, 2020 •
edited
Loading

This PR changes PerspectiveTornadoHandler to asynchronously write messages back to the client websocket using the IOLoop and add_callback, instead of the previous implementation which synchronously wrote messages. Additionally, the Tornado handler is now tested natively in Python, using Tornado's websocket_connect interface, which returns a Websocket client in Python.

  • Breaking feature
  • Non-breaking feature

Testing

New tests added for Tornado websockets in Python 2 and 3.

Checklist

  • I have read the CONTRIBUTING.md and followed its Guidelines
  • I have linted my code locally, following the project's code style
  • I have tested my changes locally, and changes pass on the Azure Pipelines CI.

@sc1f sc1f added enhancement Feature requests or improvements Python tests labels Aug 18, 2020
texodus
texodus approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Discussed offline

@texodus texodus merged commit 823bede into master Aug 26, 2020
@texodus texodus deleted the tornado-tests branch August 26, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
enhancement Feature requests or improvements Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sc1f @texodus @finos-admin