Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PR templates for bugfix, documentation, and feature #1155

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Aug 14, 2020

Adds new PR templates

I've added new PR templates for three categories:

  • Bugfix: fixes towards reported bugs on our Issues page
  • Documentation: additions/edits to API or Docusaurus documentation
  • Feature: A new feature addition to Perspective

@texodus I've added them in the same form as our issue templates, so we should be able to get the same sort of selector window that happens with issue templates - the GitHub docs are a little unclear about whether PR templates will work in the same way with the nice picker. If it doesn't work, however, happy to coalesce into one template.

Checklist

@sc1f sc1f added the enhancement Feature requests or improvements label Aug 14, 2020
@sc1f sc1f self-assigned this Aug 14, 2020
@texodus
Copy link
Member

texodus commented Aug 26, 2020

Looks like it worked

Screen Shot 2020-08-26 at 10 32 24 AM

Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This is much needed I think, thanks for taking the initiative and putting this together!

@texodus texodus merged commit cf49688 into master Aug 26, 2020
@texodus texodus deleted the pr-template branch August 26, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants