-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly display computed axis on charts, use local time for all datetime functions #1116
Conversation
…d_schema in wire api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -369,7 +369,7 @@ jobs: | |||
- script: npm install -g yarn | |||
displayName: "Install Yarn" | |||
|
|||
- script: yarn | |||
- script: yarn --network-timeout 600000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
@@ -48,6 +48,8 @@ function treemap(container, settings) { | |||
.each(function({split, data}) { | |||
const treemapSvg = d3.select(this); | |||
|
|||
console.log(split, data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug leak
Thanks for the PR! This won't be the last time we address this aggregate type, due ot the large body of work necessary to properly integrate this with sort, but its a great start! |
This PR makes several fixes to computed functions and highcharts/d3fc:
03/15/2020 23:59 EST
becomes03/16/2020 04:59 UTC
.computed_schema
on the view and on the table inPerspectiveManager
, as they have different signatures. A future improvement would be renamingTable.computed_schema
to something likeTable.get_computed_schema
, as the table method receives a set of computed columns and calculates their output types without actually creating the columns themselves.PerspectiveManager
and returns an error message iftable.delete()
is called on a remote table. Previously,table.delete()
would fail due to code flow reasons, which prevented the method from being called but is opaque. This provides a transparent error message and explanation.last by index
aggregate to usepsp_okey
instead ofpsp_pkey
in the aggspec, aspsp_pkey
does not exist in some of the intermediate data structures used during a live update. Additionally, renameAGGTYPE_LAST
toAGGTYPE_LAST_BY_INDEX
, as thelast
aggregate usesAGGTYPE_LAST_VALUE
.