Enable Manylinux wheel builds #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nux/non-manylinux
Enable wheel task for 10.14 mac Add delocate, fix wheel script Add pip install wheel to mac run add dependencies and fix py2 wheel fix py2
sc1f
added
enhancement
timkpaine
previously requested changes
May 21, 2020
Closed
|
updates:
|
|
Do you all plan to get yourselves synced up with pyarrow mainline? |
sc1f
force-pushed
the
reinvent-wheel
branch
2 times, most recently
from
26a60cd to
4e285cb
Compare
is_libpsp defaults to true print try catch islibpsp write test script go from wheelhouse only on py3 dist and build from wheelhouse
|
@texodus this should be good to go |
|
@wesm the custom arrow build we have for Emscripten might take a little fixing, but it shouldn't be too hard to get Perspective on 0.17 in the near future |
texodus
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Perspective's linux wheels fully Manylinux2010 and Manylinux2014 compatible, adds wheel build tasks for MacOS 10.14 (Mojave) and MacOS 10.15 (Catalina), as well as ensures passage of the
conda-forgeMac build.Changelog
auditwheelCMakeListsto allow full Manylinux builds to pass due to a difference betweenPYTHON_INCLUDE_DIRSandPython_INCLUDE_DIRS.auditwheel showandauditwheel repairwhenever Linux wheels are built, which ensures that all wheels are fully portable and compliant to the Manylinux PEPs.CLOCK_MONOTONICfromcompat_impl_osx, which is breaking builds onconda-forge. This is due toclock_gettimeandCLOCK_MONOTONICnot being implemented in MacOS until 10.12. Because the method that callsclock_gettimeis not used anywhere in the compiled code, I commented out the original implementation and forced the offending method to return a 0.