Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PerspectivePlugin lack dependencies #318

Closed
dknfeiov opened this issue Nov 19, 2018 · 2 comments
Closed

PerspectivePlugin lack dependencies #318

dknfeiov opened this issue Nov 19, 2018 · 2 comments
Labels
bug Concrete, reproducible bugs

Comments

@dknfeiov
Copy link
Contributor

node@8.11.2
perspective@0.2.7

Hi , i use perspective by cdn before , everything is ok , but now i want to use webpack with the plugin PerspectivePlugin supported
image
and import plugins for recommend
image
some errors happend
image
It is look like some dependence haven't list in the package.json
i view the "@jpmorganchase/perspective-viewer" package, the webpack-plugin.js use some loader and other dependences, but the package.json don't list
image
image

is the reason caused the problem ?
@LukeSheard
Copy link
Contributor

@dknfeiov I noticed this as well over the weekend. I've started work trying to fix the underlying issues here: https://github.com/jpmorganchase/perspective/tree/webpack-plugin

@LukeSheard LukeSheard changed the title PerspectivePlugin lack dependens PerspectivePlugin lack dependencies Nov 20, 2018
@texodus texodus mentioned this issue Nov 26, 2018
Merged
@timkpaine timkpaine added the bug Concrete, reproducible bugs label Dec 19, 2018
@texodus
Copy link
Member

texodus commented Dec 29, 2018 •
edited
Loading

Thanks for the report! A fix for this was merged & release in 0.2.9

@texodus texodus closed this as completed Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Concrete, reproducible bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@texodus @timkpaine @dknfeiov @LukeSheard