Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perspective Viewer not updating when group by and filter is applied #2781

Closed
yuj2i0 opened this issue Oct 4, 2024 · 4 comments · Fixed by #2784
Closed

Perspective Viewer not updating when group by and filter is applied #2781

yuj2i0 opened this issue Oct 4, 2024 · 4 comments · Fixed by #2784

Comments

@yuj2i0
Copy link

yuj2i0 commented Oct 4, 2024 •
edited
Loading

Steps to Reproduce:

I happened to come across, when I group by an column then apply an additional filter, the upgrades aren't coming through.
Checking the console logs this seems to be related to the recent binary encoding that has happened from 2.10.1 -> 3.0.0
image

It seems like once the number of character exceed 12, the encoding error appears.
Filter values works
ABCDEFGHIJKL

Filter values fails
ABCDEFGHIJKLM
AAAAAAAAAAAAA

Expected Result:

The viewer should not hang and encounter this error

Actual Result:

Refer to screenshot

Environment:

Perspective Version 3.0.3

Additional Context:
@sinistersnare
Copy link
Contributor

sinistersnare commented Oct 4, 2024 •
edited
Loading

The API changed from 2.x to 3.x so it is likely due to you not properly upgrading your code.

If you can post a reproducible example that would allow us to help, otherwise there is not enough info here to go on. Does this reproduce on the editable example?

@yuj2i0
Copy link
Author

yuj2i0 commented Oct 4, 2024 •
edited
Loading

The API changed from 2.x to 3.x so it is likely due to you not properly upgrading your code.

If you can post a reproducible example that would allow us to help, otherwise there is not enough info here to go on. Does this reproduce on the editable example?

image
Thanks for the quick reply, Yes this is reproduced in the editable example aswell, select one of the option in customer name where number of characters exceed 12
For example Adam Hart work

@sinistersnare
Copy link
Contributor

Yes, I can reproduce this by choosing "Adam Bellavance" in the example, ("Adam Hart" is not 12 characters long). Thanks for the repro!

@yuj2i0
Copy link
Author

yuj2i0 commented Oct 4, 2024 •
edited
Loading

Ah my bad for the confusion, my point was the filtering works for Adam Hart!

I think this encoding error is also causing problems when the filter is applied and the update aren't coming through to the client
You can replicate this by applying updates to Adam Bellavance when filtered on him

This encoding errors seems only appears when running in client-server replicate mode of perspective

@texodus texodus mentioned this issue Oct 6, 2024
Merged
@texodus texodus mentioned this issue Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix filter values for non-interned strings finos/perspective
2 participants
@sinistersnare @yuj2i0