Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocketClient Memory leak on send ping timeout - it should be cleared on terminate #2146

Closed
dtassone opened this issue Mar 22, 2023 · 1 comment · Fixed by #2151
Closed

WebSocketClient Memory leak on send ping timeout - it should be cleared on terminate #2146

dtassone opened this issue Mar 22, 2023 · 1 comment · Fixed by #2151

Comments

@dtassone
Copy link

dtassone commented Mar 22, 2023 •
edited
Loading

When you open a WebClientSocket and terminate. I expect the socket to not send more messages but it does as the setTimeout for sending ping messages is not cleared.

perspective/packages/perspective/src/js/websocket/client.js

Line 31 in 379cb38

setTimeout(ping, PING_TIMEOUT);

https://github.com/finos/perspective/blob/master/packages/perspective/src/js/websocket/client.js#L155
@texodus texodus mentioned this issue Mar 25, 2023
Merged
@texodus
Copy link
Member

texodus commented Mar 25, 2023

Thanks for the report, this is fixed in #2151 and will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ping loop state, make node server close method async finos/perspective
2 participants
@texodus @dtassone