Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack Example does not build #1149

Closed
hediet opened this issue Aug 6, 2020 · 2 comments
Closed

Webpack Example does not build #1149

hediet opened this issue Aug 6, 2020 · 2 comments
Labels
bug Concrete, reproducible bugs

Comments

@hediet
Copy link

hediet commented Aug 6, 2020

Bug Report

Steps to Reproduce:

  1. copy examples/webpack from e5b6e34
  2. run yarn inside the copy so that it downloads perspective from npm
  3. yarn start

Expected Result:

It serves the example.

Actual Result:

ERROR in ./node_modules/regular-table/dist/less/material.less 11:0
Module parse failed: Unexpected character '@' (11:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|  */
|
> @import (css) url("https://fonts.googleapis.com/css?family=Open+Sans");
|
| @row-height: 19px;
 @ ./node_modules/@finos/perspective-viewer-datagrid/dist/cjs/perspective-viewer-datagrid.js 1:137-185
 @ ./src/index.js
Child html-webpack-plugin for "index.html":
     1 asset
    Entrypoint undefined = index.html
    [./node_modules/html-webpack-plugin/lib/loader.js!./node_modules/html-webpack-plugin/default_index.ejs] 376 bytes {0} [built]
    [./node_modules/lodash/lodash.js] 530 KiB {0} [built]
    [./node_modules/webpack/buildin/global.js] (webpack)/buildin/global.js 472 bytes {0} [built]
    [./node_modules/webpack/buildin/module.js] (webpack)/buildin/module.js 497 bytes {0} [built]
i 「wdm」: Failed to compile.

Environment:

Node v14, Windows 10

Additional Context:

Seems like less needs to be configured. It would be cool if that wasn't necessary. I'm already using sass and don't want to install less too.

@texodus
Copy link
Member

texodus commented Aug 13, 2020

Thanks for the report - this is a recent regression of the @finos/perspective-viewer-datagrid plugin, which has a fix merged and will be released in v0.5.3

@timkpaine timkpaine added the bug Concrete, reproducible bugs label Aug 14, 2020
@texodus
Copy link
Member

texodus commented Sep 8, 2020

Fix has been released in 0.5.3

@texodus texodus closed this as completed Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

No branches or pull requests

3 participants