Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): kick off inventory project #808

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

06kellyjac
Copy link
Contributor

Track projects and their licenses
Docker compose configuration for dev with logging tracing and metrics (mostly done)
CRUD for mongo

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 6ad27bd
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/6752e37fc6d1670008e4bfea

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.11%. Comparing base (eccb4dc) to head (6ad27bd).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #808   +/-   ##
=======================================
  Coverage   63.11%   63.11%           
=======================================
  Files          47       47           
  Lines        1681     1681           
=======================================
  Hits         1061     1061           
  Misses        620      620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@06kellyjac 06kellyjac force-pushed the license_inventory_kickoff branch from 8e6fae1 to 58940c9 Compare December 2, 2024 15:52
@JamieSlome
Copy link
Member

@TheJuanAndOnly99 - are we okay to publish this library under @finos/git-proxy-license-inventory? Can you have a quick look at the publish Action and make sure you are happy from the FINOS side of the house?

Track projects and their licenses
Docker compose configuration for dev with logging tracing and metrics (mostly done)
CRUD for mongo
Addressed minor output issue
Trialed writing tests using mocks on mongoose or using an actual db
@06kellyjac 06kellyjac force-pushed the license_inventory_kickoff branch from 35fa251 to 4052420 Compare December 6, 2024 11:13
@06kellyjac 06kellyjac marked this pull request as ready for review December 6, 2024 11:13
@06kellyjac 06kellyjac force-pushed the license_inventory_kickoff branch from 4052420 to 9862e1d Compare December 6, 2024 11:15
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit fd8d09e into finos:main Dec 6, 2024
14 of 15 checks passed
@06kellyjac 06kellyjac deleted the license_inventory_kickoff branch December 6, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants