Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust auth processor to use custom service url #786

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

06kellyjac
Copy link
Contributor

Now we can override the domains used by the service and proxy
the auth processor needs to use those values

Now we can override the domains used by the service and proxy
the auth processor needs to use those values
Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 0a162b6
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/672df2c779c92100080375d0

@github-actions github-actions bot added the fix label Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.12%. Comparing base (fac98ca) to head (0a162b6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/service/urls.js 0.00% 2 Missing ⚠️
src/proxy/processors/push-action/blockForAuth.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
- Coverage   60.23%   60.12%   -0.11%     
==========================================
  Files          47       47              
  Lines        1647     1650       +3     
==========================================
  Hits          992      992              
- Misses        655      658       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome JamieSlome self-requested a review November 8, 2024 11:35
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit c87d2a0 into finos:main Nov 8, 2024
14 checks passed
@06kellyjac 06kellyjac deleted the custom_service_domain branch November 8, 2024 17:27
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
fix: adjust auth processor to use custom service url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants