Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update server start script for cross-platform compatibility #784

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

laukik-target
Copy link
Contributor

This PR updates the start script in package.json to ensure cross-platform compatibility by modifying the command syntax. The change addresses potential issues on different operating systems when running npm run server and npm run client concurrently.

Details of the Change:

The start script was modified from single quotes to double quotes to make it compatible across Windows, macOS, and Linux environments:

"start": "concurrently 'npm run server' 'npm run client'",
was updated to:
"start": "concurrently \"npm run server\" \"npm run client\"",

Reason for the Change:

  • Single quotes in scripts can cause issues on Windows systems, as they are interpreted differently. Using double quotes ensures that the command runs consistently on all platforms.

Impact:

  • This change improves the reliability of the development workflow by preventing errors related to command parsing on Windows.

Testing:

  • Verified that the start script now runs without issues on both Windows and Unix-based systems.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit f0ff239
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/672df83f40ecf10008846466

@laukik-target laukik-target changed the title Fix: Update Server Start Script for Cross-Platform Compatibility fix: update server start script for cross-platform compatibility Nov 7, 2024
@github-actions github-actions bot added the fix label Nov 7, 2024
@laukik-target
Copy link
Contributor Author

@JamieSlome one line change :)
Please review and approve.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.12%. Comparing base (c87d2a0) to head (f0ff239).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #784   +/-   ##
=======================================
  Coverage   60.12%   60.12%           
=======================================
  Files          47       47           
  Lines        1650     1650           
=======================================
  Hits          992      992           
  Misses        658      658           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome JamieSlome merged commit 3dff666 into finos:main Nov 8, 2024
14 checks passed
@JamieSlome JamieSlome self-requested a review November 8, 2024 11:43
@JamieSlome
Copy link
Member

LGTM! 🍰

Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
fix: update server start script for cross-platform compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants