Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump plugin sample to v0.1.0, add to npm publish workflow #776

Merged
merged 5 commits into from
Dec 1, 2024
Merged

feat: bump plugin sample to v0.1.0, add to npm publish workflow #776

merged 5 commits into from
Dec 1, 2024

Conversation

coopernetes
Copy link
Contributor

@coopernetes coopernetes commented Oct 30, 2024 •
edited
Loading

closes #771

On hold until after #793 is released so the samples can be updated accordingly along with the docs.

@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 53a5176
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/674b904daa88230008b67cfc

@coopernetes coopernetes added bug Something isn't working documentation Improvements or additions to documentation plugins Extensibility of the framework maintenance and removed feature labels Oct 30, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.11%. Comparing base (50ccb18) to head (53a5176).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #776   +/-   ##
=======================================
  Coverage   63.11%   63.11%           
=======================================
  Files          47       47           
  Lines        1681     1681           
=======================================
  Hits         1061     1061           
  Misses        620      620

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome
Copy link
Member

@maoo @TheJuanAndOnly99 - are we okay to publish this sample NPM project?

@TheJuanAndOnly99
Copy link
Member

@maoo @TheJuanAndOnly99 - are we okay to publish this sample NPM project?

LGTM @JamieSlome

@coopernetes coopernetes merged commit a8f5677 into finos:main Dec 1, 2024
14 checks passed
@coopernetes coopernetes deleted the feat/publish-plugin-sample branch December 1, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieSlome JamieSlome Awaiting requested review from JamieSlome

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation feature maintenance plugins Extensibility of the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to visit or install @finos/git-proxy-plugin-samples mentioned in the documentation
3 participants
@coopernetes @JamieSlome @TheJuanAndOnly99