fix: move creation of remote folder into function call #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
=======================================
Coverage 57.79% 57.79%
=======================================
Files 46 46
Lines 1597 1597
=======================================
Hits 923 923
Misses 674 674 ☔ View full report in Codecov by Sentry. |
Psingle20
pushed a commit
to Psingle20/git-proxy
that referenced
this pull request
Nov 27, 2024
fix: move creation of remote folder into function call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
pullRemote.jsis imported for the first time, the.remotefolder is created. At the end of the chain theclearBareClone.jsfunction purges the.remotefolder. This change ensures that the.remotefolder can be re-created on subsequent pushes by introducing themkdirSync()call into theexec()function which is exported and called in the chain 👍